[Dynamic Dashboard] Navigate to reviews details from reviews card #11503
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hichamboushaba
added
type: enhancement
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
hichamboushaba
commented
May 13, 2024
Comment on lines
+91
to
+102
| // Open the review list screen first as it's responsible for handling review status changes | ||
| navController.navigateSafely( | ||
| DashboardFragmentDirections.actionDashboardToReviews() | ||
| ) | ||
| // Continue to the details screen | ||
| navController.navigateSafely( | ||
| directions = DashboardFragmentDirections.actionGlobalReviewDetailFragment( | ||
| launchedFromNotification = false, | ||
| remoteReviewId = event.review.remoteId | ||
| ), | ||
| skipThrottling = true | ||
| ) |
There was a problem hiding this comment.
The ReviewListFragment is responsible for handling the undo logic of the reviews' operations (moderation and deletion), so to keep this logic while navigating from the reviews card, we needed to either:
- Implement the same logic at the dashboard level.
- Navigate to the list before showing the details.
For simplicity, I followed 2, and it works well, please let me know what you think.
hichamboushaba
commented
May 13, 2024
| ) : ScopedViewModel(savedStateHandle) { | ||
| companion object { | ||
| val supportedFilters = listOf( | ||
| ProductReviewStatus.ALL, | ||
| ProductReviewStatus.APPROVED, | ||
| ProductReviewStatus.HOLD, | ||
| ProductReviewStatus.SPAM |
There was a problem hiding this comment.
As explained here p1715612834620439/1715264194.676369-slack-C03L1NF1EA3, supporting the spam filter will require more work, so let's remove it for now.
hichamboushaba
force-pushed
the
issue/11474-dynamic-dashboard-reviews-card-3
branch
from
50692ba to
442c79f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #11503 +/- ##
============================================
- Coverage 40.67% 40.65% -0.02%
Complexity 5180 5180
============================================
Files 1070 1070
Lines 62540 62569 +29
Branches 8557 8559 +2
============================================
Hits 25438 25438
- Misses 34815 34844 +29
Partials 2287 2287 ☔ View full report in Codecov by Sentry. |
hichamboushaba
added
status: feature-flagged
Base automatically changed from
issue/11474-dynamic-dashboard-reviews-card-2
to
trunk
May 15, 2024 18:08
hichamboushaba
removed
the
status: do not merge
0nko
approved these changes
May 15, 2024
Comment on lines
+91
to
+102
| // Open the review list screen first as it's responsible for handling review status changes | ||
| navController.navigateSafely( | ||
| DashboardFragmentDirections.actionDashboardToReviews() | ||
| ) | ||
| // Continue to the details screen | ||
| navController.navigateSafely( | ||
| directions = DashboardFragmentDirections.actionGlobalReviewDetailFragment( | ||
| launchedFromNotification = false, | ||
| remoteReviewId = event.review.remoteId | ||
| ), | ||
| skipThrottling = true | ||
| ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #11474
Description
This PR adds logic for navigating to the review details from the reviews card, please check the comments for more details on the approach.
Testing instructions
Images/gif
Screen_recording_20240513_171822.mp4
RELEASE-NOTES.txtif necessary. Use the "[Internal]" label for non-user-facing changes.